[NFC] Fix unary minus operator on unsigned type warning #153887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: warning C4146: unary minus operator applied to unsigned type, result still unsigned
|
@llvm/pr-subscribers-llvm-ir Author: None (Nadharm) ChangesFixes: Full diff: https://github.com/llvm/llvm-project/pull/153887.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/BasicBlock.h b/llvm/include/llvm/IR/BasicBlock.h
index c24f01fe26cc8..533808e0666d5 100644
--- a/llvm/include/llvm/IR/BasicBlock.h
+++ b/llvm/include/llvm/IR/BasicBlock.h
@@ -68,7 +68,7 @@ class BasicBlock final : public Value, // Basic blocks are data objects also
// Allow Function to renumber blocks.
friend class Function;
/// Per-function unique number.
- unsigned Number = -1u;
+ unsigned Number = ~0u;
friend class BlockAddress;
friend class SymbolTableListTraits<BasicBlock>;
|
|
@AlexMaclean could you merge this for me please? I don't have permissions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
warning C4146: unary minus operator applied to unsigned type, result still unsigned